Upgrade to Kotlin 2.1.10 #44497
Open
Upgrade to Kotlin 2.1.10 #44497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
|
Thanks for the PR. Unfortunately, moving the examples to a It hides the Java sources from Kotlin compilation. |
wilkinsona
added
the
status: waiting-for-feedback
|
@wilkinsona thanks for the feedback.
Yes, I wasn't sure about this approach. I changed and was able to build the docs locally without a problem. Anyway I'll fix the PR according to your suggestion. |
spring-projects-issues
added
status: feedback-provided
- Upgrade kotlinVersion to 2.1.10 - Remove org.jetbrains.kotlin:kotlin-compiler-embeddable from dependencies - Replace deprecated kotlinOptions with compilerOptions - Update KotlinConventions of ConventionsPlugin to set Kotlin apiVersion and languageVersion to 2.1 - Fix redeclaration error with Kotlin compiler on spring-boot-doc - Upgrade PluginClasspathGradleBuild to inject missed Kotlin compiler related jars See spring-projectsgh-38539 Signed-off-by: Dmitry Sulman <[email protected]>
dmitrysulman
force-pushed
the
kotlin-2.1.10-migration
branch
from
1d9bbc4 to
d757a21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to Kotlin 2.1.10:
kotlinVersionto2.1.10org.jetbrains.kotlin:kotlin-compiler-embeddablefrom the classpath, see: https://kotl.in/gradle/internal-compiler-symbolskotlinOptionswithcompilerOptions, see: https://kotl.in/u1r8lnKotlinConventionsofConventionsPluginto set KotlinapiVersionandlanguageVersionto2.1PluginClasspathGradleBuildto inject missed Kotlin K2 compiler related jars for running Kotlin Gradle plugin tests on Gradle 8.11+, see Gradle compatibility matrix for Kotlin: https://docs.gradle.org/current/userguide/compatibility.html#kotlinMove all Kotlin examples ofspring-boot-doctokotlinsubpackage to preventRedeclaration:compile errors, see: https://youtrack.jetbrains.com/issue/KTLC-85/Forbid-Java-and-Kotlin-classes-with-the-same-FQ-name-in-sources. This fix introduces most of the changes in the commit.javaSourcesfrom theKotlinCompiletask ofspring-boot-doc, except for Java classes that are used by some Kotlin example classes, to avoid a redeclaration error with the Kotlin compiler.See gh-38539